Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
4 of 6 tasks
afercia
force-pushed
the
prevent-unnecessary-announcements-media-theme-browsers
branch
from
October 6, 2026 11:02
6c2e909 to
63ef239
Compare
afercia
changed the title
afercia
added
the
props-bot
github-actions
Bot
removed
the
props-bot
afercia
force-pushed
the
prevent-unnecessary-announcements-media-theme-browsers
branch
from
October 8, 2026 10:58
63ef239 to
015d05c
Compare
afercia
force-pushed
the
prevent-unnecessary-announcements-media-theme-browsers
branch
from
October 8, 2026 11:30
015d05c to
1dc9ff8
Compare
wporg-sync
pushed a commit
that referenced
this pull request
Oct 8, 2026
…nts when navigating the media and theme browsers. In the various media and theme browsers, the announcements for screen readers were sometimes too noisy because focus was set too often and unnecessarily on some elements. To improve the announcements and move focus only when really necessary, all the media and theme browsers are now standardized to the following pattern: - Makes sure all the media and theme browsers have a dialog role. - Keeps the navigation buttons focusable by using `aria-disabled` instead of `disabled`. - Ensures that screen reader announcements are cleaner by keeping focus on the activated control rather than moving it to another element. - Makes sure initial focus is set to the dialog element when it is opened. - Makes sure to return focus to the opener control when the dialog is closed. - Makes sure the opener control is a focusable element. - Adjusts styles accordingly to take the `aria-disabled` attribute into account. - Simplifies the buttons accessible name to: Previous / Next / Close. - Makes sure the ARIA live regions are not hidden when they inherit `visibility: hidden`. Developed in #13816 Props sukhendu2002, khokansardar, afercia. Fixes #65746. git-svn-id: https://develop.svn.wordpress.org/trunk@64241 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Oct 8, 2026
…nts when navigating the media and theme browsers. In the various media and theme browsers, the announcements for screen readers were sometimes too noisy because focus was set too often and unnecessarily on some elements. To improve the announcements and move focus only when really necessary, all the media and theme browsers are now standardized to the following pattern: - Makes sure all the media and theme browsers have a dialog role. - Keeps the navigation buttons focusable by using `aria-disabled` instead of `disabled`. - Ensures that screen reader announcements are cleaner by keeping focus on the activated control rather than moving it to another element. - Makes sure initial focus is set to the dialog element when it is opened. - Makes sure to return focus to the opener control when the dialog is closed. - Makes sure the opener control is a focusable element. - Adjusts styles accordingly to take the `aria-disabled` attribute into account. - Simplifies the buttons accessible name to: Previous / Next / Close. - Makes sure the ARIA live regions are not hidden when they inherit `visibility: hidden`. Developed in WordPress/wordpress-develop#13816 Props sukhendu2002, khokansardar, afercia. Fixes #65746. Built from https://develop.svn.wordpress.org/trunk@64241 git-svn-id: http://core.svn.wordpress.org/trunk@63392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/65746
Use of AI Tools
None
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.