Repository navigation

Code Quality: Declare conditional return types where an argument selects the return type. - #13614

Closed

westonruter wants to merge 33 commits into

WordPress:trunkfrom

westonruter:add/conditional-return-types

Closed

Code Quality: Declare conditional return types where an argument selects the return type.#13614
westonruter wants to merge 33 commits into
WordPress:trunkfrom
westonruter:add/conditional-return-types

Commits on Sep 19, 2026
- Add a conditional return type to `WP_Comment_Query::query()`.
  
  westonruter
  and
  claude
  committed
  64b91ee
- Add conditional return types for the `$output` parameter of term and category getters.
  
  westonruter
  and
  claude
  committed
  489bb4d
- Add a conditional return type to `get_page_by_title()`.
  
  westonruter
  and
  claude
  committed
  1080486
- Add conditional return types for site and network queries.
  
  westonruter
  and
  claude
  committed
  8bc2330
- Add a conditional return type to `get_users()`.
  
  westonruter
  and
  claude
  committed
  b6c6df3
- Add conditional return types for date and time format parameters.
  
  westonruter
  and
  claude
  committed
  0e9daed
- Add a conditional return type to `WP_Theme::display()`.
  
  westonruter
  and
  claude
  committed
  46c51a4
- Add conditional return types for boolean output-shape flags.
  
  westonruter
  and
  claude
  committed
  1f2cfd5
- Type the shape of the `WP_Theme` header pipeline.
  
  westonruter
  and
  claude
  committed
  792f9e9
- Add conditional return types to `has_filter()` and `has_action()`.
  
  westonruter
  and
  claude
  committed
  323670c
- Add conditional return types for two private helpers, and correct one `@return`.
  
  westonruter
  and
  claude
  committed
  4f7bb29
- Spell the `has_filter()` union as `false|int` and drop the PHPStan workaround.
  
  westonruter
  and
  claude
  committed
  b27a941
- Bring in the conditional return types from the WordPress stubs' function map.
  
  westonruter
  and
  claude
  committed
  3f38f79
- Adopt the stubs' `get_bookmark()` conditional, and revive `get_link()` with it.
  
  westonruter
  and
  claude
  committed
  a3fbdcf
- Add the remaining conditional return types from the stubs' function map.
  
  westonruter
  and
  claude
  committed
  98f5f28
Commits on Sep 20, 2026
- Write the empty array shape as `array{}`.
  
  westonruter
  and
  claude
  committed
  9e7fb8b
- Correct return type of wp_get_link_cats() to account for WP_Error
  westonruter
  committed
  c348216
Commits on Sep 21, 2026
- Widen five conditional return types that claimed more than core delivers.
  
  westonruter
  and
  claude
  committed
  637431f
Commits on Sep 25, 2026
- Merge branch 'trunk' into add/conditional-return-types
  westonruter
  committed
  a5ec73b
- Remove the `wp_allow_comment()` conditional return type, and correct its `@return`.
  
  westonruter
  and
  claude
  committed
  2c2ae25
- Allow `false` from `wp_set_comment_status()` for an unrecognized status.
  
  westonruter
  and
  claude
  committed
  66b5dd0
- Account for uppercase `'Y'` in the `bool_from_yn()` return type.
  
  westonruter
  and
  claude
  committed
  3235534
- Correct the `rest_sanitize_boolean()` return type for bools and mixed-case strings.
  
  westonruter
  and
  claude
  committed
  8fdbf08
- Limit the non-negative `sanitize_term_field()` return to the raw context.
  
  westonruter
  and
  claude
  committed
  b6c4a97
- Only rule out an empty-string tag in the `has_shortcode()` return type.
  
  westonruter
  and
  claude
  committed
  a7e73e1
- Type user IDs from `get_users()` as numeric strings.
  
  westonruter
  and
  claude
  committed
  d89cfda
- Name the `'queue'` status correctly in the `WP_Dependencies::query()` return type.
  
  westonruter
  and
  claude
  committed
  1f149d3
- Stop ruling out a revision for post ID 0 in `wp_is_post_revision()`.
  
  westonruter
  and
  claude
  committed
  03bc410
- Remove the `get_block_wrapper_attributes()` conditional return type.
  
  westonruter
  and
  claude
  committed
  54fb380
Commits on Sep 26, 2026
- Allow `null` from `paginate_links()` when the total is not passed.
  
  westonruter
  and
  claude
  committed
  9cf9ae4
- Allow an integer zero in the `get_categories()` count return type.
  
  westonruter
  and
  claude
  committed
  7e7fc47
- Drop the non-negative claim from the `wp_insert_link()` return type.
  
  westonruter
  and
  claude
  committed
  92a18c8
- Merge branch 'trunk' into add/conditional-return-types
  westonruter
  committed
  b7f087f

Commits

Commits on Sep 19, 2026

Commits on Sep 20, 2026

Commits on Sep 21, 2026

Commits on Sep 25, 2026

Commits on Sep 26, 2026