JSHint: Exclude minified plugin files more effectively. by afercia · Pull Request #13573 · WordPress/wordpress-develop

afercia · 2026-09-17T08:10:30Z

Trac ticket: https://core.trac.wordpress.org/ticket/66123

Exclude minified files from the grunt jshint:plugins task by checking the JS files line length.
The assumption is that when a JS file contains lines with a length that is longer than 500 characters, then it is considered a minified file and it will be skipped.

Use of AI Tools

AI assistance: Yes
Tool(s): GitHub Copilot
Model(s): Claude Haiku 4.5
Used for: Initial research and suggestions; final implementation and tests were reviewed and edited by me.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

github-actions · 2026-09-17T08:10:40Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props afercia, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2026-09-17T08:13:33Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

westonruter · 2026-09-21T17:45:52Z

+					for ( var i = 0; i < Math.min( lines.length, 5 ); i++ ) {
+						// Exclude files with lines longer than 500 characters.
+						if ( lines[i].length > 500 ) {


This can be simplified:

Suggested change

for ( var i = 0; i < Math.min( lines.length, 5 ); i++ ) {

// Exclude files with lines longer than 500 characters.

if ( lines[i].length > 500 ) {

for ( const line of lines.slice( 0, 5 ) ) {

// Exclude files with lines longer than 500 characters.

if ( line.length > 500 ) {

This would create a new array, right? A negligible overhead though, fine with it.

afercia · 2026-09-21T19:02:45Z

@@ -1086,25 +1086,53 @@ module.exports = function(grunt) {
 				/*


Note that this was not a docblock, just a block comment. Now that we add param and return tags, it needs to use a double asterisk.

Copilot

Copilot review overview

🟡 Changes recommended

The path resolution currently causes failures, and the scan does not inspect the entire file.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 · 1

Open (2)

Resolve filter paths relative to target cwd · New
Scan all lines when detecting long lines · New

What changed in this PR

Updates grunt jshint:plugins to exclude minified JavaScript files based on line length.

Changes:

Adds minified-file detection.
Preserves directory filtering.
Improves documentation and logging.

File	Summary
`Gruntfile.js`	Updates plugin JSHint filtering and minified-file detection.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+					// Bypasses folder targets so fs.readFileSync doesn't throw errors.
+					if ( ! fs.lstatSync( dirpath ).isFile() ) {
+						return false;


westonruter · 2026-09-21T19:54:44Z

+					var lines = content.split( '\n' );
+
+					// Cap the maximum number of iterations at 5 lines.
+					for ( const line of lines.slice( 0, 5 ) ) {


This makes sense to me. Iterating over all lines in an an array is extremely fast, especially as the lines are already in memory.

We don't have to aim for perfection.
Also I'd like to remind that in https://core.trac.wordpress.org/ticket/65950 I'm asking to consider whether jshint:plugins is still useful to some extend in the first place.
Honestly, I think it is not really used by developers to check their own plugins as today more modern and efficient tools are in use. I would consider to just remove this task.

…more effectively. Follow-up to [63364]. Prevents `grunt jshint:plugins` from scanning minified JavaScript files that don't use a `.min` suffix in their filename. Assumes that JavaScript files that contain lines with a length that is longer than 500 characters are minified file and skips them. Developed in #13573 Props afercia, westonruter. Fixes #66123. git-svn-id: https://develop.svn.wordpress.org/trunk@63783 602fd350-edb4-49c9-b593-d223f7449a82

…more effectively. Follow-up to [63364]. Prevents `grunt jshint:plugins` from scanning minified JavaScript files that don't use a `.min` suffix in their filename. Assumes that JavaScript files that contain lines with a length that is longer than 500 characters are minified file and skips them. Developed in WordPress/wordpress-develop#13573 Props afercia, westonruter. Fixes #66123. Built from https://develop.svn.wordpress.org/trunk@63783 git-svn-id: http://core.svn.wordpress.org/trunk@62955 1a063a9b-81f0-0310-95a4-ce76da25c4cd

afercia · 2026-09-21T19:57:59Z

Committed in https://core.trac.wordpress.org/changeset/63783

afercia force-pushed the jshint-exclude-minified-files-with-no-min-filename-suffix branch 2 times, most recently from bde0cfc to 909ba30 Compare September 17, 2026 08:53

afercia requested a review from westonruter September 20, 2026 11:08

afercia force-pushed the jshint-exclude-minified-files-with-no-min-filename-suffix branch from 909ba30 to 8354c5a Compare September 21, 2026 17:31

westonruter reviewed Sep 21, 2026

View reviewed changes

JSHint: Exclude minified plugin files more effectively.

b7e8225

afercia commented Sep 21, 2026

View reviewed changes

Address CR feedback.

8d31caf

afercia force-pushed the jshint-exclude-minified-files-with-no-min-filename-suffix branch from 8354c5a to 8d31caf Compare September 21, 2026 19:06

westonruter requested a lite review from Copilot September 21, 2026 19:51

afercia added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Sep 21, 2026

github-actions Bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Sep 21, 2026

Copilot started reviewing on behalf of westonruter September 21, 2026 19:52

View session

Copilot AI reviewed Sep 21, 2026

View reviewed changes

afercia closed this Sep 21, 2026

afercia deleted the jshint-exclude-minified-files-with-no-min-filename-suffix branch September 21, 2026 19:58

Navigation Menu

Repository navigation

JSHint: Exclude minified plugin files more effectively. - #13573

JSHint: Exclude minified plugin files more effectively.#13573
afercia wants to merge 2 commits into
WordPress:trunkfrom
afercia:jshint-exclude-minified-files-with-no-min-filename-suffix

afercia commented Sep 17, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 17, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 17, 2026

Uh oh!

Uh oh!

westonruter Sep 21, 2026

Uh oh!

afercia Sep 21, 2026

Uh oh!

afercia Sep 21, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

westonruter Sep 21, 2026

Uh oh!

afercia Sep 21, 2026

Uh oh!

afercia commented Sep 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -1086,25 +1086,53 @@ module.exports = function(grunt) {
		/*

Conversation

afercia commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Use of AI Tools

Uh oh!

github-actions Bot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 17, 2026

Test using WordPress Playground

Some things to be aware of

Uh oh!

Uh oh!

westonruter Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

afercia Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

afercia Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

westonruter Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

afercia Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

afercia commented Sep 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

afercia commented Sep 17, 2026 •

edited

Loading

github-actions Bot commented Sep 17, 2026 •

edited

Loading