Skip to content

Try caching wp_get_global_styles - #13214

Closed
tellthemachines wants to merge 1 commit into
WordPress:trunkfrom
tellthemachines:add/wp_get_global_styles_cache
Closed

tellthemachines wants to merge 1 commit into
WordPress:trunkfrom
tellthemachines:add/wp_get_global_styles_cache

Conversation

@tellthemachines

Copy link
Copy Markdown
Contributor

Copies PR WordPress/gutenberg#81889 over to core. Trac ticket to come

Trac ticket:

Use of AI Tools


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@sirreal

sirreal commented Sep 3, 2026

Copy link
Copy Markdown
Member

I discovered this independently: #13192

I abandoned that approach in favor of WordPress/gutenberg#81979. Before landing this, let's consider whether we should go with that instead (I'd expect it to revert changes from WordPress/gutenberg#81889)

@peterwilsoncc

Copy link
Copy Markdown
Contributor

@tellthemachines @sirreal I'm catching up on the WordPress 7.2 PHP backport ticket: is this likely to be included in the release?

@tellthemachines

Copy link
Copy Markdown
Contributor Author

I haven't looked closely at @sirreal's alternative PR but at first glance it seems to be a more solid solution performance-wise. I guess we'll need to get it merged in Gutenberg first, then do a core sync PR as alternative to this one.

@sirreal

sirreal commented Oct 7, 2026

Copy link
Copy Markdown
Member

I cleaned up WordPress/gutenberg#81979 which may supersede this depending on review.

@sirreal

sirreal commented Oct 7, 2026

Copy link
Copy Markdown
Member

#14071 would supersede this if WordPress/gutenberg#81979 lands.

@tellthemachines

Copy link
Copy Markdown
Contributor Author

closing in favour of #14071.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants