Repository navigation
Conversation
sirreal
marked this pull request as ready for review
July 14, 2026 12:21
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
…removal-self-close
…ames_with_prefix(). When a slash precedes a removed attribute, `remove_attribute()` enqueues a single space instead of an empty string so the slash does not become a self-closing flag. `get_enqueued_attribute_value()` already treats that space as a removal, but `get_attribute_names_with_prefix()` only recognized the empty string, so it kept listing the removed attribute until the updates were applied. See #65967.
Adds tests that remove one attribute from tags where slashes separate attributes, follow the tag name, end an unquoted value, or form the self-closing flag, and where another attribute directly follows a quoted value. Each test re-parses the updated HTML and asserts that the tag name, the self-closing flag, the remaining attributes, and the following text are unchanged, so a stray or missing separator fails the test even when the expected string is wrong. Ported from WordPress#13208, with the expected strings updated to the single space this change writes in place of a slash-preceded attribute. See #65967.
…ame. `set_attribute()` and `add_class()` insert new attributes directly after the tag name. When only a slash separates the tag name from an attribute that is then removed, the insertion and the removal are a single byte apart. These tests apply both in either order, with a self-closing flag, with another attribute following, and with two removals of different attributes, then re-parse the updated HTML and assert the tag name, self-closing flag, attributes, and following text. Ported from WordPress#13208, with the expected strings updated to this change's output and a re-parse check added. See #65967.
…tribute with a space. Documents that a `/` directly before an attribute can only be a separator, why leaving it before `>` would add a self-closing flag, and which readers treat the single-space replacement as a removal. The explanation of why the `/` is always a separator comes from WordPress#13208. See #65967.
The tests added with this change named #65372, the closed 7.1 ticket. The change belongs to #65967. See #65967.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing an attribute could accidentally change tag semantics. For example, removing attr from
<svg><g /attr>okproduced<svg><g />ok, producing a self-closing flag on thegtag that was not present before.Trac ticket: https://core.trac.wordpress.org/ticket/65967
Alternative to #12368.
Use of AI Tools
AI assistance: Yes
Tool(s): Codex, Claude Code
Model(s): GPT-5, Opus 5.5, Fable 5.1
Used for: Diagnosis, tests, implementation, adversarial review, and verification. All generated changes were reviewed before submission.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.