Skip to content

Quick/Bulk Edit: Restore compact size of inline edit select#11631

Open
t-hamano wants to merge 2 commits intoWordPress:trunkfrom
t-hamano:64685-restore-select-compact-size
Open

Quick/Bulk Edit: Restore compact size of inline edit select#11631
t-hamano wants to merge 2 commits intoWordPress:trunkfrom
t-hamano:64685-restore-select-compact-size

Conversation

@t-hamano
Copy link
Copy Markdown
Contributor

Trac ticket: https://core.trac.wordpress.org/ticket/64685

The height of elements in the Quick Edit UI was unified to 32px by r61827. However, subsequent changes in r62171 unintentionally removed the line-height not only from input elements but also from select elements. As a result, the following styles were applied to select elements, causing their height to unintentionally revert to 40px.

.wp-core-ui select {
	line-height: 2.71428571; /* 38px for 40px min-height */
}

This PR restores the appropriate line-height value to achieve the 32px height.

Screenshots

Before

image

After

image

Use of AI Tools

None

@t-hamano t-hamano self-assigned this Apr 23, 2026
@t-hamano t-hamano marked this pull request as ready for review April 23, 2026 03:31
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add a note for future reference so this doesn’t get removed again?

Annotate the `line-height` value so future readers understand how it maps to the 32px select height at the default 14px font size.

See #64685.
@t-hamano
Copy link
Copy Markdown
Contributor Author

t-hamano commented Apr 23, 2026

Do we need to add a note for future reference so this doesn’t get removed again?

Nice idea, addressed in #92bc76698d8c45eaf2d9eae60fceefb5d64152d2

P.S. I also propose removing hardcoded line-height values from all select elements in the future, as it can sometimes be difficult to predict the final element height. However, we need to confirm that removing the line-height does not cause any issues. See https://core.trac.wordpress.org/ticket/62864#comment:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants