Quick/Bulk Edit: Restore compact size of inline edit select#11631
Quick/Bulk Edit: Restore compact size of inline edit select#11631t-hamano wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Do we need to add a note for future reference so this doesn’t get removed again?
Annotate the `line-height` value so future readers understand how it maps to the 32px select height at the default 14px font size. See #64685.
Nice idea, addressed in #92bc76698d8c45eaf2d9eae60fceefb5d64152d2 P.S. I also propose removing hardcoded line-height values from all select elements in the future, as it can sometimes be difficult to predict the final element height. However, we need to confirm that removing the line-height does not cause any issues. See https://core.trac.wordpress.org/ticket/62864#comment:23 |
Trac ticket: https://core.trac.wordpress.org/ticket/64685
The height of elements in the Quick Edit UI was unified to 32px by r61827. However, subsequent changes in r62171 unintentionally removed the line-height not only from input elements but also from select elements. As a result, the following styles were applied to select elements, causing their height to unintentionally revert to 40px.
This PR restores the appropriate line-height value to achieve the 32px height.
Screenshots
Before
After
Use of AI Tools
None