Switch to PCOV for the coverage report runner#11618
Open
johnbillion wants to merge 5 commits intoWordPress:trunkfrom
Open
Switch to PCOV for the coverage report runner#11618johnbillion wants to merge 5 commits intoWordPress:trunkfrom
johnbillion wants to merge 5 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
johnbillion
requested review from
SergeyBiryukov,
aaronjorbin,
desrosj and
swissspidy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using Xdebug in coverage mode to generate a coverage report, we can use PCOV.
This has reduced the test coverage step time from around 50 minutes to around 25. A comparable unit test step without coverage takes around 11 minutes. I was expecting the time reduction to be even greater, but it's still a 50% saving.
It might be worth installing PCOV directly into the container images. This PR installs it prior to running the coverage tests but it only takes a few seconds. A task for another time.
Trac ticket: https://core.trac.wordpress.org/ticket/64893
Why has the HTML report generation been removed?
It creates a 400MB artifact that expands to 7GB of HTML files. Many of them are unusable. We've got Codecov for this reason.
Why has the coverage changed?
The Codecov coverage report is showing a -0.5% coverage reduction with this change. The source code itself has not changed, the change comes from the differences in reporting between Xdebug and PCOV. The PCOV docs notes a difference in
switchhandling, for example.What about phpdbg?
PCOV is faster and more accurate than phpdbg, although admittedly there aren't a huge number of comparisons available. Regardless, PHPUnit as of version 10 no longer supports phpdbg for coverage reporting so PCOV is a better choice for future-proofing.
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Opus 4.7
Used for: Initial planning for the switch to PCOV. Tweaked and verified by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.