Skip to content

Rewrite: Skip verbose page rules when permalink structure has a disambiguating stub#11608

Open
himanshupathak95 wants to merge 4 commits intoWordPress:trunkfrom
himanshupathak95:fix/9824
Open

Rewrite: Skip verbose page rules when permalink structure has a disambiguating stub#11608
himanshupathak95 wants to merge 4 commits intoWordPress:trunkfrom
himanshupathak95:fix/9824

Conversation

@himanshupathak95
Copy link
Copy Markdown

@himanshupathak95 himanshupathak95 commented Apr 20, 2026

Trac ticket: https://core.trac.wordpress.org/ticket/9824

When a permalink structure like /news-and-events/%postname%/ is used, the existing regex incorrectly sets use_verbose_page_rules to true. The regex ^[^%]*%(?:postname|category|tag|author)% matches any non-% characters before the tag, including literal path stubs. This causes pages and paginated archive URLs to resolve incorrectly, because rewrite rule ordering and the extra get_page_by_path() disambiguation check are applied when they aren't needed.

This PR fixes that by using a tighter regex (^/?%(?:postname|category|tag|author)%) that only matches when the ambiguous tag is the very first path component. When a literal stub like /news/ precedes the tag, verbose page rules are correctly skipped.

Props mdawaffe for the original Trac patch.

Testing

Run tests by -

npm run test:php -- --filter=Tests_Rewrite

Use of AI Tools

For creating and testing the regex

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@himanshupathak95 himanshupathak95 marked this pull request as ready for review April 21, 2026 15:49
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props abcd95.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant