Rewrite: Skip verbose page rules when permalink structure has a disambiguating stub#11608
Rewrite: Skip verbose page rules when permalink structure has a disambiguating stub#11608himanshupathak95 wants to merge 4 commits intoWordPress:trunkfrom
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
e7ef6ad to
9ae8f6b
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Trac ticket: https://core.trac.wordpress.org/ticket/9824
When a permalink structure like
/news-and-events/%postname%/is used, the existing regex incorrectly setsuse_verbose_page_rulesto true. The regex^[^%]*%(?:postname|category|tag|author)%matches any non-% characters before the tag, including literal path stubs. This causes pages and paginated archive URLs to resolve incorrectly, because rewrite rule ordering and the extra get_page_by_path() disambiguation check are applied when they aren't needed.This PR fixes that by using a tighter regex
(^/?%(?:postname|category|tag|author)%)that only matches when the ambiguous tag is the very first path component. When a literal stub like /news/ precedes the tag, verbose page rules are correctly skipped.Props mdawaffe for the original Trac patch.
Testing
Run tests by -
Use of AI Tools
For creating and testing the regex