Skip to content

Users: Add id="user-{ID}" to rows on WP_MS_Users_List_Table #11600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dd32 wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Users: Add id="user-{ID}" to rows on WP_MS_Users_List_Table #11600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wp-admin/includes/class-wp-ms-users-list-table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ public function display_rows() {
}

?>
<tr class="<?php echo trim( $class ); ?>">
<tr id="user-<?php echo (int) $user->ID; ?>" class="<?php echo trim( $class ); ?>">
Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casting here not necessary here

Copy link
Copy Markdown
Member

@westonruter westonruter Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't hurt though. Since WP_User::$ID doesn't have a PHP property type specified, technically someone could populate a $user->ID = '" onclick="alert(1)'.

<?php $this->single_row_columns( $user ); ?>
</tr>
<?php
Expand Down
Loading