Repository navigation

Code Editor: Improve types and options handling - #10900

Closed

westonruter wants to merge 80 commits into

WordPress:trunkfrom

westonruter:fix/wp-code-editor-types-and-options

Closed

Code Editor: Improve types and options handling#10900
westonruter wants to merge 80 commits into
WordPress:trunkfrom
westonruter:fix/wp-code-editor-types-and-options

Commits on Feb 10, 2026
- Modernize code-editor.js with const and let.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  b54a88b
- Code Editor: Fix JSDoc types for CodeMirror instances.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  ce4192b
- Replace deprecated substr() with slice().
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  ef4352c
- Replace deprecated event.keyCode with event.key.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  c76450f
Commits on Feb 11, 2026
- Pass Underscore to IIFE and add JSDoc types.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  68967d4
- Define and use CodeEditorSettings typedef.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  49ab652
- Make CodeEditorSettings sub-properties optional.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  d3d39e9
- Refine CodeEditorInstance and initialize types.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  7bd58f0
- Refine CodeMirror settings types in CodeEditorSettings.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  1569be3
- Use public CodeMirror API for wrapper element.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  55a86e9
- Use native Node.contains() instead of jQuery.contains().
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  d2dddab
- Use native Element.classList instead of jQuery.hasClass().
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  7bdadc7
- Fix logic error when calling overridden onUpdateLinting.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  7aa5359
- Use specific CodeMirror.EditorFromTextArea type for editor instances.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  0eab515
- Fix unresolved performLint() and improve CodeMirror types.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  c3f6261
- Use native filter() for annotations to improve type inference.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  dfffb19
- Add types for CodeMirror state and token state.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  651b325
- Enhance CodeMirror type definitions for better IDE compatibility.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  cfa9f8a
- Ensure shouldAutocomplete is always boolean.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  81db304
- Use getDoc method
  westonruter
  committed
  c4cb899
Commits on Feb 12, 2026
- Try alternative typedef
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  75173fd
Commits on Feb 14, 2026
- Merge branch 'trunk' into fix/wp-code-editor-types-and-options
  westonruter
  committed
  b27dcd9
- Build Tooling: Introduce TypeScript checking for JavaScript files via JSDoc.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  f5bcb81
- Code Editor: Refactor JSDoc types for TypeScript compatibility.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  c5e8db3
- Code Editor: Refine type definitions and resolve unused variable warnings.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  b4eda5b
- Code Editor: Simplify type casts in optionChange handler.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  835a3d9
- Code Editor: Add explicit types for mousedown event handler.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  6cf7940
- Code Editor: Cast fromTextArea return value to CodeMirrorEditor.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  1bad754
- Code Editor: Refine CodeMirror types and integrate addon definitions.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  b23615c
- Code Editor: Prevent redundant linting pass during initialization.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  dd7579f
- Code Editor: Remove obsolete nested 'options.options' for linting.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  70e4196
- Build Tooling: Reorganize CodeMirror source files.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  9cbfb44
- Code Editor: Enable TypeScript checking for CodeMirror extensions.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  8570258
- Code Editor: Refactor htmlhint-kses.js to modern syntax.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  26b7cee
- Code Editor: Use for...of loop in htmlhint-kses.js.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  339fe05
- Code Editor: Use template literals in htmlhint-kses.js.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  393b360
- Code Editor: Add HTMLHint types to htmlhint-kses.js.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  6d5374a
- Eliminate abbreviated variables
  westonruter
  committed
  493be25
- Code Editor: Strengthen TypeScript checking with specific JSDoc types.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  b16bfaa
- Code Editor: Enable strict TypeScript checking.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  c8a795a
- Code Editor: Refine linting types and reduce 'any' usage.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  6fe9a8e
- Code Editor: Use flat linting options and refine intersection type.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  6489ad0
- Code Editor: Refine linting types and eliminate 'any' usage.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  6a94d99
- Code Editor: Remove remaining 'any' type and streamline event listeners.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  bdc959f
- Break up long conditional line and remove redundant types
  westonruter
  committed
  ffb7bcc
- Eliminate redundancy in setting same-named variable to key in object literal
  westonruter
  committed
  81179e8
- Code Editor: Add trailing commas to multi-line object literals.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  ba15ab7
- Code Editor: Refine local ESLint configuration.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  666a2c1
- Address ESLint complaints with htmlhint-kses.js
  westonruter
  committed
  bf2f382
- Code Editor: Apply Prettier formatting to htmlhint-kses.js.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  0147a63
- Build Tooling: Revert esprima.js build source to node_modules.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  d33a45c
- Build Tooling: Remove redundant esprima.js source file.
  
  westonruter
  and
  gemini-code-assist[bot]
  committed
  b693399
Commits on Feb 15, 2026
- Use typecheck:js instead of static-analysis:js
  
  westonruter
  and
  justlevine
  authored
  7505032
Commits on Feb 17, 2026
- Merge branch 'trunk' into fix/wp-code-editor-types-and-options
  westonruter
  authored
  b0a53a4
Commits on Feb 22, 2026
- Merge branch 'trunk' of https://github.com/WordPress/wordpress-develop into fix/wp-code-editor-types-and-options
  westonruter
  committed
  6d0d9ee
- Ignore jshint error
  westonruter
  committed
  8c78893
- Add file docblock for fakejshint.js
  westonruter
  committed
  2f4a6a2
- Move fakejshint.js to deprecated directory
  
  westonruter
  and
  gemini-cli
  committed
  f0ea1df
- Add link to ticket which introduced Espree
  westonruter
  committed
  b47db54
- Add W058 to ignored JSHint errors
  westonruter
  committed
  c8911e3
- Remove accidentally-committed symlink-js-enqueues.sh
  westonruter
  committed
  8211a45
- Merge branch 'trunk' of https://github.com/WordPress/wordpress-develop into fix/wp-code-editor-types-and-options
  westonruter
  committed
  ef18c0c
- Enhance global type definitions for jQuery and Underscore.
  
  westonruter
  and
  gemini-cli
  committed
  3be7a13
- Undo some needless modifications to global handling
  westonruter
  committed
  5f54c0b
Commits on Feb 23, 2026
- Typings: Simplify globals.d.ts by removing redundant Window augmentation.
  
  committed
  df54173
- fixup! Typings: Simplify globals.d.ts by removing redundant Window augmentation.
  westonruter
  committed
  6ab382c
Commits on Mar 3, 2026
- Merge branch 'trunk' into fix/wp-code-editor-types-and-options
  sirreal
  committed
  bf45a14
- Move project declaration files from source to types
  sirreal
  committed
  5d895d2
- Use tsconfig files instead of includes
  sirreal
  committed
  43e51ee
- Use modern "tsc --build"
  sirreal
  committed
  d01237c
- Add schema and reformat tsconfig.json
  sirreal
  committed
  8add99b
- Update some tsconfig settings
  sirreal
  committed
  8b2e015
- Add a few more tsconfig options
  sirreal
  committed
  521ffb3
- Fix Object type -> Record<k,v>
  sirreal
  committed
  81d741a
- Remove `jQuery` from param type
  sirreal
  committed
  9338964
- Remove deprecated tsconfig esmoduleinterop option
  sirreal
  committed
  b5dd3f0
- switch to tsgo
  sirreal
  committed
  62eec88
- Revert "switch to tsgo"
  sirreal
  committed
  b4c8cd8
- Revert "Remove `jQuery` from param type"
  westonruter
  committed
  5192ff9
- Correct jQuery types
  sirreal
  committed
  ed9f7b0

Commits

Commits on Feb 10, 2026

Commits on Feb 11, 2026

Commits on Feb 12, 2026

Commits on Feb 14, 2026

Commits on Feb 15, 2026

Commits on Feb 17, 2026

Commits on Feb 22, 2026

Commits on Feb 23, 2026

Commits on Mar 3, 2026