Repository navigation
Page Header Variants through Style Options - #6727
Merged
Merged
Conversation
…Node::isCurrentNode()`
… dropdown and drawer-ready avatar button
… bootstrap to drawers
…ware priority+ overflow for the system page header
…st language switcher
… the system page header
…'s sticky offsets
…tDimmedText to meet AA
… them against their enum
…issing or deprecated values on import
…enus to the bar bottom
…egular flag/bell icons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a lot of new features that enable us to offer different page header variants. This also introduces a modernized variant of the mobile menu that is now consistent between smartphones and tablets.
This also lays out the path for future modernizations of the style by offering more customization options without requiring additional CSS by the user.
One important aspect is that we moved the CSS a bit around to conditionally load only the CSS for either the classic or the new header variants. Templates are also compatible because we added a dynamic overruling of the
pageHeaderinclude by directing it to a system template. System templates are maintained exclusively by us and to enable seamless upgrades, these templates are not customizable.Closes #5704
Fully Backwards Compatible
The legacy page header (dubbed “classic”) remains available and all previous styles default to this version. We made the decision to keep it fully backwards compatible by shipping the new HTML, CSS and JS alongside the existing ones, allowing for a friction-less migration.
Previews
Disclaimer: The screenshots are from an active development version and are subject to change.
Switching Between Page Header Variants
New: Page Logo Above the Menu
New: Combined Logo + Menu