fix(gso): off by one error in gsoSplit on linux - #151
Open
encodeous wants to merge 1 commit into
Open
Conversation
Signed-off-by: Adam Chen <encodeous7@gmail.com>
encodeous
force-pushed
the
ac/wg-gsosplit-obo
branch
from
July 26, 2026 00:06
8d39475 to
26c47ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream contrib of encodeous/nylon#140
gsoSplitreturns number of packets read / buffers populated.However, we return:
Meaning that we exclude the last packet only if we reach the end of the buffer. This seems like a logic error.