Repository navigation
refactor!: cli-core 0.319.0 — no default profile - #709
Merged
Merged
Conversation
cli-core 0.319.0 stops reading default_profile: a config that still has it stops a command naming no profile, with the profile to type and `max config unset default_profile`. A profile called `default` is an ordinary name, so `mcp config` names its server `max-default`. - `max config set default_profile` is refused; `unset` still removes a leftover one (max's own changeSetting mirrors cli-core's). - SessionStore no longer falls back to profile "default": callers pass the profile. Only tests relied on the fallback. - Dropped the unused DEFAULT_PROFILE constant. - Docs, skill and the commands.md intro no longer offer default_profile. - CHANGELOG: what to do instead (`max <profile> …`, unset), plus the 0.317.0 task-rule and edit-merge fixes users will notice. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Move
@wirecat/cli-corefrom 0.315.0 to 0.319.0 (cli-core#1432) and follow the owner's ruling: no default profile, only an explicit one.Why
cli-core 0.319.0 no longer reads
default_profile. max has its ownconfig setpath and aSessionStorethat still fell back to the profiledefault— both an implicit profile choice the owner ruled out.What
default_profilestops a command naming no profile, with the profile to type andmax config unset default_profile.max config set default_profileis refused;unsetstill clears it.defaultis ordinary:mcp confignames its servermax-default.SessionStorerequiresprofile(no"default"fallback). Only tests relied on it; they now pass it explicitly. UnusedDEFAULT_PROFILEremoved.docs/*.md,skills/max-cli/SKILL.md, the commands.md intro (scripts/commands.ts) no longer offerdefault_profile.Testing
pnpm typecheck,pnpm lint(4 pre-existing warnings in untouched files),pnpm docs:check,pnpm parity:checkpnpm test:matrix: full vitest suite green; matrix 911 tested, 159 untested with a reason, 0 missing🤖 Generated with Claude Code