Repository navigation
fix: retain runtime coverage for Semgrep TypeScript parse failures - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinned Semgrep can fail to parse entire modern TypeScript files. Preserve the original report, compile only those failed files with pinned esbuild, and scan their runtime JavaScript with source maps back to the original source. Compilation, parser errors or missing runtime coverage still fail the run; type-only syntax remains an explicit limitation.
Run scanners independently and keep Stop hooks disabled during continuation work. Validation: full lint, typecheck, coverage (100% lines), docs and Bun smoke passed; regression cases cover finding mapping, compiler/parser failures, missing coverage and outside-root paths. An archived public messaging snapshot recovered four full-file parser failures while retaining partial-parser warnings.