Repository navigation
fix(agent): verify fixtures across per-account dialogs - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Private dialogs can use different peer addresses and message IDs on each account. The agent fixture runner previously sent/deleted using the owner's dialog address and checked the sender's message ID in the owner's history.
The private cast now supports
SENDER_DIALOGandPER_ACCOUNT_IDS=1. Per-account readback requires a unique synthetic fixture label, refuses ambiguous matches before model execution, and deletes using the sender's ID before checking the label is gone from the owner's side. Existing shared-ID behavior remains the default.Validation: 54 tests passed; 100% line/function coverage; lint, types, docs, Bun and shell syntax checks passed. Synthetic subprocess tests cover differing addresses/IDs, missing markers, ambiguous matches, and cleanup/runtime failures. No account-specific configuration is committed.