custom.js: fix invalid CSS selector in VAT country sync - #4308
Merged
Merged
Conversation
Member
|
@codex review |
nijel
enabled auto-merge (rebase)
September 21, 2026 11:38
Member
|
Scheduled for merge, thanks for your contribution! |
nijel
disabled auto-merge
September 21, 2026 11:38
nijel
enabled auto-merge (squash)
September 21, 2026 11:38
Contributor
Author
|
@nijel Waiting For Approval. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4308 +/- ##
==========================================
- Coverage 91.85% 91.81% -0.05%
==========================================
Files 76 76
Lines 16692 16692
Branches 1404 1404
==========================================
- Hits 15333 15325 -8
- Misses 943 949 +6
- Partials 416 418 +2 🚀 New features to boost your workflow:
|
Contributor
Author
|
@nijel Thanks For Quickly Merge Can i have delete this fork ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4307
In
weblate_web/static/custom.js, the VAT form selector contained aU+00B7 MIDDLE DOT (
·) instead of a descendant combinator (space):`#id_country·option[value="${value}"]`This made
querySelector()returnnull, throwingTypeError: Cannot set properties of null (setting 'selected')whenever theVAT country field changed, so the country
<select>was never synced.Fix: replace the middle dot with a space.