Let actor storage own both KV surfaces - #26
Merged
Conversation
The synchronous and asynchronous storage views share one SQLite owner, codec, and list compiler. Keeping the sync view in a separate module created an import cycle, duplicate types, and forwarding helpers with no independent responsibility. Colocate the implementation with DurableObjectStorage, use native iteration, and keep compiler and codec details private.
MiguelsPizza
marked this pull request as ready for review
August 23, 2026 15:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The synchronous and asynchronous Durable Object storage views share one SQLite owner, codec, and list compiler. Splitting the sync view into a second module created an import cycle, duplicate types, and forwarding helpers with no independent responsibility.
What changed
Net result: 106 fewer lines and the actor-state/sync-kv import cycle is gone.
Validation
Related work
Draft only; do not merge without Alex explicit approval.