Improve end2end test runner - #563
Open
camillobruni wants to merge 9 commits into
Open
Conversation
✅ Deploy Preview for webkit-speedometer-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| "test-e2e:chrome": "node tests/run-end2end.mjs --browser chrome", | ||
| "test-e2e:firefox": "node tests/run-end2end.mjs --browser firefox", | ||
| "test-e2e:safari": "node tests/run-end2end.mjs --browser safari", | ||
| "test-e2e:edge": "node tests/run-end2end.mjs --browser edge", |
There was a problem hiding this comment.
I think this change isn't necessary, but I don't mind.
| close() { | ||
| ws.server.close(); | ||
| }, | ||
| }; |
There was a problem hiding this comment.
I think the outer close is dead now, so you should probably remove it.
| switch (BROWSER) { | ||
| case "safari": { | ||
| if (isHeadless) | ||
| console.warn("Warning: --headless is not supported with safari, running in windowed mode."); |
Andrew-Fryer
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.