Repository navigation
Specify DynamicsCompressorNode makeup gain control - #2641
Merged
Merged
Conversation
Member
Author
|
TPAC 2025 notes:
|
mjwilson-google
marked this pull request as draft
November 25, 2025 20:26
padenot
approved these changes
Sep 15, 2026
mjwilson-google
force-pushed
the
makeup-gain
branch
from
October 25, 2026 11:57
4057738 to
7c8429d
Compare
mjwilson-google
marked this pull request as ready for review
October 25, 2026 12:00
padenot
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2639.
I picked the parameter bounds to be the same as for the filter node gain.
I'm not sure if this is the best way to specify the behavior:
default-notes?Preview | Diff