Skip to content

Use same consent config with sdk and whitelabel#2471

Merged
chaitanyapotti merged 2 commits intomasterfrom
feat/update-consent-sdk-config
May 11, 2026
Merged

Use same consent config with sdk and whitelabel#2471
chaitanyapotti merged 2 commits intomasterfrom
feat/update-consent-sdk-config

Conversation

@lionellbriones
Copy link
Copy Markdown
Contributor

@lionellbriones lionellbriones commented May 7, 2026

Jira Link

Description

Sdk config for consent required is not the same with whitelabel config (which configurable on dashboard also)

  • fix demo: if consent required we add sample links for privacy and tnc (links should be showing on consent screen now)
  • fixed some logic on consentRequired (it can only be true if privacy and tnc links are also provided)
  • fixed primary button hover effect for accept consent UI

How has this been tested?

Screenshots (if appropriate)

Privacy and Terms links are showing now
Screenshot 2026-05-07 at 12 13 34 PM

Hover effects on accept button is fixed as well
Screenshot 2026-05-07 at 12 14 32 PM
Screenshot 2026-05-07 at 12 14 18 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Note

Medium Risk
Changes the public consent configuration shape and the runtime gating for consent, which could break apps still using the old uiConfig.consentConfig or expecting consent to trigger without policy/terms links.

Overview
Unifies “consent required” configuration by removing uiConfig.consentConfig and switching to top-level uiConfig.consentRequired plus privacyPolicy/tncLink across the modal SDK and demo apps.

Tightens consent behavior so consent is only treated as required when both consentRequired is true and privacyPolicy/tncLink are provided, and updates Web3Auth/LoginModal to derive consentRequired from the modal instance during init.

Includes a small UI tweak to the consent accept button hover/border styling and updates tests to match the new config.

Reviewed by Cursor Bugbot for commit d613770. Bugbot is set up for automated code reviews on this repo. Configure here.

@lionellbriones lionellbriones requested review from a team as code owners May 7, 2026 04:20
@vercel
Copy link
Copy Markdown

vercel Bot commented May 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web3auth-web Ready Ready Preview, Comment May 7, 2026 4:45am

Request Review

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit fbd7a00. Configure here.

Comment thread demo/wagmi-react-app/src/App.tsx Outdated
@chaitanyapotti chaitanyapotti merged commit d482d3c into master May 11, 2026
4 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/update-consent-sdk-config branch May 11, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants