Repository navigation
fix(transactions): resolve order URI via connection in create (#16) - #26
Merged
aaronelliotross merged 1 commit intoOct 7, 2026
Merged
Conversation
In Transactions.create(), calling Orders.get_resource_uri_from_id(order_id) unbound on the class passed order_id as self, leaving resource_id unfilled and raising TypeError. Resolve the order URI via self.connection.get_resource_uri_from_id with Orders.resource_name, and update the test to assert payload dispatch. Fixes WeMoveEU#16
aaronelliotross
self-requested a review
October 7, 2026 09:29
aaronelliotross
approved these changes
Oct 7, 2026
aaronelliotross
left a comment
aaronelliotross
left a comment
Collaborator
There was a problem hiding this comment.
@DevMubarak1 Thanks for the PR, looks good ! From the language in the PR, I'm guessing this was an AI authored fix. Either way, thanks again !
Contributor
Author
|
@aaronelliotross Haha, busted on the description. Used an LLM to help draft the writeup but tested and verified the fix thoroughly. Appreciate the fast review and merge Aaron. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16
The defect
Transactions.create()calledOrders.get_resource_uri_from_id(order_id)directly on theOrdersclass rather than on an instance or via the underlying connection. BecauseHttpMethods.get_resource_uri_from_id(self, resource_id)is an instance method, calling it unbound boundorder_idtoselfand leftresource_idunfilled, raising:Any call to
Transactions.create()providingorder_idinstead oforder_uricrashed before reaching the network.Fix
Call
self.connection.get_resource_uri_from_id(order_id, Orders.resource_name)to build the order resource URI.Verification
Updated
tests/test_transactions.py::test_create_with_order_id_is_broken(renamed totest_create_with_order_id_sends_expected_payload) to assert successful POST dispatch with the generated order URI. All 11 transaction tests pass.