Skip to content

Cpjump1 example training data access refactor#29

Merged
wli51 merged 5 commits into
WayScience:mainfrom
wli51:cpjump1-data-access-refactor
Jun 10, 2026
Merged

Cpjump1 example training data access refactor#29
wli51 merged 5 commits into
WayScience:mainfrom
wli51:cpjump1-data-access-refactor

Conversation

@wli51

@wli51 wli51 commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Change way of example CPJUMP1 data access uses existing manifest and metadata files from WayScience/JUMP-single-cell.

Addresses issue #26

Note that this PR only adds an additional 0.*.ipynb for example data download and does not yet replace the old data access notebook and subsequent training, which I decided to save for a separate PR to keep the size in check.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@wli51 wli51 requested a review from MattsonCam May 27, 2026 21:52

@MattsonCam MattsonCam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @wli51 , good job!

Comment thread examples/nbconverted/0.download_example_dataset.py
Comment thread examples/nbconverted/0.download_example_dataset.py
Comment thread src/virtual_stain_flow/datasets/example/cpjump1_manifest.py Outdated
Comment thread src/virtual_stain_flow/datasets/example/cpjump1_manifest.py Outdated
Comment thread examples/nbconverted/0.download_example_dataset.py Outdated
Comment thread examples/nbconverted/0.download_example_dataset.py Outdated
@wli51

wli51 commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks @MattsonCam for reviewing. Merging now!

@wli51 wli51 merged commit 96077a3 into WayScience:main Jun 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants