Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A concurrent keyed create can read an absent dashboard, then lose the title claim after another node commits the same request and activates its title. It currently returns
409 title_conflictinstead of replaying the durable create receipt.On that title-conflict path only, reread the deterministic dashboard receipt and use the existing replay helper. Matching requests return current configuration and the original applied revision, including after a later edit. Different arguments retain
idempotency_conflict; a distinct key retainstitle_conflict. The retry does not rewrite the document or title.Stack: depends on prerequisite draft #51; base is
dashboard/prerequisite-agent-api(54e8de3352e3804586952f90b3c02aa4a0345804), notmain. Onlysrc/users/dashboard_service.rschanges in this layer: the exact supplied fix and regression (158 additions / 3 deletions). Keep draft until the prerequisite's public API compatibility/security/resource-cost blockers and remaining validation are resolved. No broader compatibility claim is made here.The regression pauses an actual absent read while another service commits, then covers four cases: identical create; identical create after a later edit; same key/different arguments; distinct key/same title. Each checks one document and unchanged stored document/title versions after the late replay or conflict.
Fresh verification: exact patch applicability and reverse check; one-file stack diff; baseline SHA-256
ef366d16c2e8d178b16cbf80a504708e70304feb253adefcb76c89e0bed3a38b; resulting SHA-2567686f9e862c8b27f6db9d63bdfb73dbcbabcf8707f4c30014f6555ad82f1c8c1;/home/ajs/.cargo/bin/rustfmt --check --edition 2024 --config skip_children=true src/users/dashboard_service.rs;git diff --check: all passed.Not freshly executed: Rust compilation/test suite and this four-case regression; current CI pending. Historical R81 reconstructed-overlay evidence (835 passed / 1 ignored and the four race subcases) is not a fresh branch test. The prerequisite's fresh 62-test frontend run, TypeScript, formatting and Python syntax checks are documented in #51; the race layer does not change frontend code. No new Rust build target, server, benchmark, dependency installation, merge, or deployment was performed.
Need help on this PR? Tag
@codesmith-botwith what you need.