Repository navigation
Add persistent drag-and-drop column ordering to field tables - #47
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Reviewed PR #47 at 18ec1e45 against 63a95b90 using Sol 6.1. One actionable accessibility issue found. Reviewed the full diff and surrounding persistence/table code; reproduced the issue in Chromium against the checkout with mocked API responses.
There was a problem hiding this comment.
Independent review: column ordering and preferences (PR #47)
Reviewer model: Claude Opus 5.5 (claude-opus-5-5)
Reviewed SHA: 18ec1e45 (base 63a95b90)
I read the full base..HEAD diff and the code around it: LogsPage view and dataset-reset flow, logViewReducer, VirtualLogTable windowing and keyboard handling, SQL run, draft and library persistence, DashboardTile/TileChart call sites, and ResultsCard. I checked the two findings below against a local Vite dev server (demo mode, port 5197) using throwaway Playwright scripts outside the repo. I did not change any tracked files.
Two actionable findings: one Medium (accessibility) and one Low (UX). I found no persistence or correctness regressions. The per-user, per-server and per-table key isolation, malformed-storage handling, explicit shared-view precedence, SQL draft and library round-tripping, and SQL schema reconciliation behave as their tests describe.
Field tables now support dragging column-header grips to change display order. Logs and SQL also provide draggable selected fields and earlier/later buttons in the column picker; arrow keys work on every grip. Sorting and row values stay aligned in both paginated and virtualized tables.
Column preferences persist per server and user: Logs remembers selections per dataset, Metrics remembers table order, and dashboards remember each tile independently. Explicit log views and shared links preserve their own order. SQL drafts and saved queries retain selections and order across reruns/reloads, while newly returned fields appear without revealing fields the user intentionally hid.
Validation:
Preferences are browser-local except when included in existing server-backed saved log views. This PR does not deploy the frontend.
Need help on this PR? Tag
@codesmith-botwith what you need.