Repository navigation
Add searchable dataset pickers to dashboards - #46
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dashboard defaults previously required typing a dataset name without a way to browse existing datasets. This adds a searchable dropdown to dashboard defaults, dataset-variable defaults, and tile dataset selection. Opening the picker lists available datasets; typing ranks exact, prefix, substring, abbreviation, and small-typo matches. For example,
aplgsfindsapi_logsandapplication_logs.Screenshots and demo
Captured in the demo workspace using sample data.
Browse existing datasets
Fuzzy search —
aplgsfinds matching dataset names.New tiles inherit the selected default
Watch the 18-second MP4 demo: change an existing dashboard default using fuzzy search, keyboard selection, Apply, and Save · Video file
Validation
Review follow-up: Opus 5.5 reproduced a false unavailable label for saved
${source}dataset-variable bindings with a failing browser regression, then fixed it. Sol 6.1 independently approved the fix; missing references still receive unavailable labels. See the resolved review thread.dashboards,dashboard-editor,dashboard-layout-sections,dashboard-builder-regressions): 80 passed.git diff --checkpassed.Browser tests use mocks and the demo workspace. Live ingestion/query validation was not run; the live dashboard test selectors were updated for the new combobox.
This PR has: