Skip to content

Add tooltips to event field actions - #43

Merged
VibeSWE merged 1 commit into
mainfrom
fix/event-field-tooltips
Oct 16, 2026
Merged

VibeSWE merged 1 commit into
mainfrom
fix/event-field-tooltips

Conversation

@VibeSWE

@VibeSWE VibeSWE commented Oct 16, 2026 •

Copy link
Copy Markdown

Event detail field actions currently expose only icons, leaving their behavior unclear on hover. Add native tooltips explaining that the filter buttons include or exclude events with the field value, and that copy copies the field name and value.

Validation: Prettier, TypeScript (tsc --noEmit), and the existing Playwright event field search/JSON/exclusion test passed.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@comment-clanker comment-clanker Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed commit ecb9471 with four independent agents: two GPT-6.1-Sol reviews (handler semantics and component compatibility) and two Claude Opus 5.5 reviews (UX/accessibility and change risk).

No actionable introduced issues found. The filter tooltips describe equality/exclusion correctly; copy describes the field name and value. Button forwards title to the native button, and existing accessible names and handlers are unchanged. The parent verified the diff contains only three title attributes in RecordSheet.tsx.

Validation passed locally: Prettier, TypeScript, and the existing Playwright event field search/JSON/exclusion test. The Opus reviewers used direct source reads because their shell temporary directory exceeded its quota; they did not independently run tests. Native hover tooltips follow the current UI convention; keyboard-focus/touch tooltips are a possible future enhancement, not a regression.

CI is still pending. Merge only after checks succeed and no unresolved review issues remain.

@VibeSWE
VibeSWE merged commit b8d7f42 into main Oct 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant