Repository navigation
feat(keystone): add native investigations, scoped runs and canvas - #40
Merged
Merged
Conversation
There was a problem hiding this comment.
Independent review of head 1bf6a86122fe4eea348022c1c4163da880136eb4 against base bd20b0431ab2e5a50d8e159bb01ae19f72487778, with Opus 5.5 and Sol 6.1 reviewers. One confirmed frontend cancellation-contract defect is detailed below. The scoped backend review found no additional material defects.
Validation: rebuilt this head and ran the Rust Keystone tests (136 passed); independently reproduced the adapter failure with synthetic responses. Frontend browser suites and live provider inference were not run for this review.
VibeSWE
marked this pull request as ready for review
October 14, 2026 03:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Native Keystone previously showed a capability notice. This adds private, durable investigations: users save a question as a draft, explicitly run it against an approved dataset/time scope, inspect evidence and progress, and create follow-up or Explore cards from a completed direct parent.
Child context contains only the selected direct parent's versioned own prompt, completed answer, approved scope and explicitly exported authorized evidence, plus the child prompt and system/tool instructions. It does not inherit sibling or hidden ancestor transcripts or provider-held conversation state.
Validation
Validated from isolated source snapshots; production source matches the final reviewed snapshot. Independent Opus reviews found no remaining blockers in the reviewed scope.
npm run check, pinned Playwright CI containerThe redundant lightweight Rust harness was retired before committing: all 91 test functions it imported, including every name from its historical 73-test result, are present in the main suite. A fresh post-retirement run passed all 136 Keystone tests. No coverage was removed or hidden behind conditional skips.
Deployment and validation limits
CFLAGS=-std=gnu17, CMake 3.31.8, andCMAKE_POLICY_VERSION_MINIMUM=3.5for GCC 16/bundled Kafka dependencies. These were environment overrides, not repository changes.Reviewer guide
Start with foundation and deployment contracts, then provider/security behavior and browser validation. Backend domain/context/repository/coordinator code is under
src/keystone; native query integration changes are in catalog/query/storage/RBAC. UI components and fixtures are underfrontend/src/features/keystone, with strict transport contracts underfrontend/src/lib/keystone.This PR has:
Need help on this PR? Tag
@codesmith-botwith what you need.