Repository navigation
chore: sync upstream parseablehq/parseable (#1819) - #20
Conversation
* update tools that use single dataset * coderabbit comment fix
Brings in acc9148 "update tools that use single dataset (parseablehq#1819)". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Reviewed PR #20 at ec9c3f4caebb3274ff34ba66da5f9567e038fb3f against 14f287c827945b37ce514b6baa4ce7b854c3ff64, with three independent GPT-6.1-Sol sub-agent reviews covering schemas and API contracts, executor correctness, and callers and authorization. No actionable bugs found in this diff.
Both trace tools consistently require a nonempty dataset string. Dataset-scoped query authorization, tenant and session propagation, query authentication headers, trace dataset validation, time bounds, limits, and SQL escaping remain intact. Repository searches found no callers or examples still passing the old datasets argument. The removal of implicit discovery and multi-dataset queries matches the stated change.
Validation: cargo test --lib tool_ passed all 11 tests, and git diff --check passed. The two changed files match the upstream merge parent. The existing tool tests cover catalog, validation, registry caching, and authentication; they do not exercise a successful trace query against a running server.
Merges
upstream/maininto the fork. Upstream has one new commit since v3.2.5:The
get_tracesandget_traceLLM tools now take one requireddatasetstring, replacing the optionaldatasetsarray (up to 10). They no longer fall back to scanning every visible trace dataset. Onlysrc/tool_catalog.rsandsrc/tool_executor.rschange. The fork hasn't modified either file, and the native frontend doesn't call these tools.The merge is clean.
cargo test --lib tool_passes 11 of 11.Use "Create a merge commit" when merging, not squash or rebase, so upstream ancestry is kept and later syncs stay clean.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.