Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.20.2 fixed MC-109346, meaning players will render with the correct head yaw when they're tracked without movement. I think it's good to match the fix to the versions downstream, especially considering 1.8 and 1.9 weren't affected, as they would send a head rotation packet even for players. Currently, players spawn facing south on all versions below 1.20.2, and this is noticeable on NPCs or AFK players.
Technically it's not exactly the same because, at least in 1.20, this change is interpolated over 3 ticks but subsequent head look updates will override this without issues. And this is translated to a head rotation packet in 1.8 which has no interpolation so it behaves exactly the same as it would on a 1.8 server.