Change resin trim material to gold for 1.21.2 clients - #1330
Conversation
aaf4a99 to
0b38567
Compare
|
|
||
| // Change resin trim material to gold | ||
| final ArmorTrim1_20_5 trim = dataContainer.get(StructuredDataKey.TRIM1_21_4); | ||
| if (trim != null && trim.material().id() == 10) { |
There was a problem hiding this comment.
Trim materials are synchronized, not static/hardcoded. If you want to change anything about them, you need to update the registry data
There was a problem hiding this comment.
That makes sense, thanks! Is there a way to have it resolve the translatable in description too? I've noticed the string is present in the translation mappings, but it still appears as trim_material.minecraft.resin in game. I would imagine it'd have to be rewritten somewhere, but if so shouldn't it be earlier in the chain?
There was a problem hiding this comment.
That needs rewriting inside registry data, too
There was a problem hiding this comment.
I see, so if they end up adding another material type the protocol responsible for it will add another description rewrite step? This should be good to go then
There was a problem hiding this comment.
The description should be rewritten in VV in every version, working on that right now as we are missing a few more rewritables for Components in registries.
There was a problem hiding this comment.
Nice, I reverted my last change following ViaVersion/ViaVersion#5077
f66c2e8 to
9608045
Compare
9608045 to
e3c020a
Compare
3 participants
Fixes resin trimmed armor appearing with missing textures/model. I tried copper too and IMO gold gets closer.
Screenshots
Server:
1.21.2 client (before):
1.21.2 client (after):
