Skip to content

feat: preview module definitions in tag completions - #116

Merged
ViTeXFTW merged 3 commits into
devfrom
t3code/implement-feature-request
Sep 8, 2026
Merged

ViTeXFTW merged 3 commits into
devfrom
t3code/implement-feature-request

Conversation

@ViTeXFTW

@ViTeXFTW ViTeXFTW commented Sep 5, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • show the defining module header as Markdown documentation for RemoveModule/ReplaceModule tag completions
  • preserve module preview metadata across workspace indexing and inherited default tags
  • add analysis, conversion, and end-to-end coverage

Validation

  • cargo test
  • python crates/server/tests/e2e.py target/debug/zerosyntax-lsp.exe

@greptile-apps

greptile-apps Bot commented Sep 5, 2026 •

Copy link
Copy Markdown

Greptile Summary

This PR adds Markdown previews of defining module headers to RemoveModule and ReplaceModule tag completions while preserving the required metadata through indexing, caching, and LSP conversion.

  • Extends completion and module-tag metadata with documentation snippets.
  • Propagates module previews through workspace indexing and inherited default tags.
  • Converts previews to LSP Markdown documentation.
  • Adds analysis, conversion, and end-to-end coverage.
  • Bumps the persistent cache producer ABI for the serialized metadata change.

Confidence Score: 5/5

The PR appears safe to merge with no outstanding correctness, security, or repository-rule issues.

The previous cache-format finding was fully addressed by bumping the persistent workspace cache producer ABI from v2 to v3, and its thread was manually resolved. No changes were made after the previous review, and no new actionable findings remain.

Important Files Changed

Filename Overview
crates/analysis/src/completion.rs Adds Markdown documentation to module-tag completions and unit coverage for defining-module previews.
crates/analysis/src/index.rs Captures module header snippets and preserves them through workspace and inherited-tag indexing.
crates/server/src/cache.rs Bumps the cache producer ABI so records using the previous serialized module-tag shape are not reused.
crates/server/src/convert.rs Converts analysis documentation into LSP Markdown completion documentation with unit coverage.
crates/server/tests/e2e.py Verifies that RemoveModule completions expose the defining module header as Markdown.

Reviews (3): Last reviewed commit: "fix: bump workspace cache producer ABI" | Re-trigger Greptile

Comment thread crates/analysis/src/index.rs
@ViTeXFTW

ViTeXFTW commented Sep 5, 2026

Copy link
Copy Markdown
Owner Author

@greptileai

@greptile-apps

greptile-apps Bot commented Sep 5, 2026

Copy link
Copy Markdown

Want your agent to iterate on Greptile's feedback? Try greploops.

@ViTeXFTW

ViTeXFTW commented Sep 8, 2026

Copy link
Copy Markdown
Owner Author

@greptile review

…re-request

# Conflicts:
#	crates/analysis/src/completion.rs
@ViTeXFTW
ViTeXFTW merged commit 2f0b829 into dev Sep 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant