SDK Delta V2 docs#3
Open
andriy-shymkiv wants to merge 2 commits into
Open
Conversation
Velenir
reviewed
May 27, 2026
|
|
||
| await sdk.deltaV2.approveTokenForDelta("1000000000000000000", DAI); | ||
|
|
||
| const auction = await sdk.deltaV2.submitDeltaOrderV2({ |
Member
There was a problem hiding this comment.
I think this will look much nice if we drop V2 suffix for methods.
sdk.deltaV2.submitDeltaOrder
I left a comment to that effect in your SDK PR
Velenir
reviewed
May 27, 2026
| **Delta V2 vs V1.** V2 sends `partner` / `partnerAddress` / `partnerFeeBps` straight to the server, which resolves and validates them — no extra round-trip. V1 calls `getPartnerFee(partner)` locally inside `buildDeltaOrder` (response is cached per partner). Either way the fee lands on-chain at settlement; the V2 path is just one fewer network call. | ||
| </Note> | ||
|
|
||
| If you need the registered defaults programmatically (e.g., to show "0.25% fee" in your UI), call `getPartnerFee` directly: |
Member
There was a problem hiding this comment.
Maybe
Suggested change
| If you need the registered defaults programmatically (e.g., to show "0.25% fee" in your UI), call `getPartnerFee` directly: | |
| If you need to obtain the registered defaults programmatically (e.g., to show "0.25% fee" in your UI), call `getPartnerFee` directly: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of FRNT-1333