Let <url> stop a link from auto-embedding - #1651
Open
SkyJoshua wants to merge 1 commit into
Open
Conversation
Wrapping a link in angle brackets already renders it as a plain clickable link (standard markdown), but it would still generate a preview card. Now it doesn't.
Deploying valour with
|
| Latest commit: |
63f257c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d60451da.valour.pages.dev |
| Branch Preview URL: | https://feat-no-embed-brackets.valour.pages.dev |
SigmaTel71
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1509. Wrapping a link in angle brackets (
<https://app.valour.gg>) already renders as a plain clickable link via standard markdown — no code change needed there, Markdig already handles it natively. What didn't work was the server still generating a preview/embed card for that URL regardless. Now it doesn't: a bracketed link is skipped when scanning message content for embeds.This also sidesteps the underlying complaint in the issue about embeds being unreliable to remove after the fact (missing close button on hover, embed reappearing after refresh) — since the embed is never created at send time for a bracketed link, there's nothing to get stuck.
Changes
ProxyHandler.GetUrlAttachmentsFromContentnow skips embed generation for any URL match immediately preceded by<and followed by>in the raw message contentVideos
url.Example.mp4