Disable product telemetry in every workflow - #1709
Draft
RhysSullivan wants to merge 1 commit into
Draft
Conversation
The first pass only covered the workflows that looked like they ran product code and missed preview, deploy, pkg-pr-new and publish-executor-package, which also invoke the CLI. Blacksmith runners kept reporting to the production PostHog project after the fix merged. Apply the opt-out at the top level of every workflow instead of guessing. The variables are inert where the product is not executed.
Contributor
Cloudflare preview
Sign-in is Cloudflare Access (one-time PIN to an allowed email). The preview has its own database and encryption key; it is destroyed when this PR closes. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 51f8dcc | Commit Preview URL Branch Preview URL |
Aug 20 2026, 05:24 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 51f8dcc | Aug 20 2026, 05:24 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1701, which did not fully stop the leak.
That PR added the opt-out only to the workflows that looked like they ran product code (ci, publish-selfhost-docker, publish-desktop, release). Blacksmith runners kept reporting to production PostHog after it merged —
hitevents fromexecutor/stable/1.5.42/cliwere still arriving 100 minutes later. The missed workflows arepreview,deploy,pkg-pr-newandpublish-executor-package, which also invoke the CLI.Rather than guess again, this applies the opt-out at the top level of every workflow. The variables are inert where the product is not executed, so there is no cost to the blanket application and no next workflow can silently reintroduce it.
Verified all 9 workflows now carry all three variables and still parse.
Note one residual source this cannot fix:
pull_requestruns use the workflow file from the PR head branch, so open PRs branched before #1701 keep the old file until they rebase. That decays on its own.