Skip to content

Drop the e2e assertion contradicting the Google scope allowlist #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RhysSullivan merged 1 commit into from
Aug 19, 2026
Merged

Drop the e2e assertion contradicting the Google scope allowlist #1700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions e2e/scenarios/first-party-oauth.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,9 +221,14 @@ scenario(
expect(google.origin.allowedScopes).toContain(
"https://www.googleapis.com/auth/meetings.space.readonly",
);
expect(google.origin.allowedScopes).not.toContain(
"https://www.googleapis.com/auth/gmail.modify",
);
// `gmail.modify` stays in the host-enforced allowlist on purpose: a
// connection created before the full-Gmail review still declares it, and
// `resolveFirstPartyScopes` filters discovered scopes through this list,
// so dropping it would break those reconnects — as the legacy-spec case
// further down this file asserts. The invariant that new Gmail presets
// request `mail.google.com` instead lives in the preset unit tests
// (packages/plugins/openapi/.../presets.test.ts), which is where the
// request-side scope choice is actually decided.
expect(google.origin.allowedScopes).toContain("https://mail.google.com/");
expect(google.origin.allowedScopes).toContain(
"https://www.googleapis.com/auth/gmail.settings.basic",
Expand Down
Loading