Skip to content

Recognize vite strictPort exits as port collisions in claimAndBoot - #1662

Merged
RhysSullivan merged 1 commit into
mainfrom
e2e-strictport-retry
Aug 18, 2026
Merged

Recognize vite strictPort exits as port collisions in claimAndBoot#1662
RhysSullivan merged 1 commit into
mainfrom
e2e-strictport-retry

Conversation

@RhysSullivan

Copy link
Copy Markdown
Collaborator

Sixth CI e2e flake from PR #1648's runs: a cloud shard died at boot with BootProcessExitError — vite --strictPort exited with "Port 44550 is already in use".

The boot glue already handles exactly this: claimAndBoot bind-probes a port block and, on a collision between probe release and the service's bind (a Linux ephemeral outbound socket can grab the port in that window), re-claims the next block and retries. But the retry only engages when isAddrInUse recognizes the failure, and vite's strictPort exit never says EADDRINUSE — the CLI catches the bind error and dies with "Port N is already in use", which reaches the setup only inside the boot log tail. So the retry never fired and the shard failed on attempt 1.

isAddrInUse now also matches that phrasing (verified against the exact error shape from the failed run: detected, and unrelated boot failures still are not).

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Cloudflare preview

Torn down — the PR is closed.

@pkg-pr-new

pkg-pr-new Bot commented Aug 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@1662

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@1662

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@1662

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@1662

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@1662

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@1662

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@1662

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@1662

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@1662

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@1662

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@1662

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@1662

executor

npm i https://pkg.pr.new/executor@1662

commit: 898c147

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud 898c147 Aug 18 2026, 05:51 PM

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing 898c147 Commit Preview URL

Branch Preview URL
Aug 18 2026, 05:50 PM

@RhysSullivan
RhysSullivan marked this pull request as ready for review August 18, 2026 17:56
@RhysSullivan
RhysSullivan merged commit 586a9c0 into main Aug 18, 2026
43 checks passed
@RhysSullivan
RhysSullivan deleted the e2e-strictport-retry branch August 18, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant