Skip to content

Poll the emulator ledger instead of racing its write - #1661

Merged
RhysSullivan merged 1 commit into
mainfrom
e2e-emulator-ledger-poll
Aug 18, 2026
Merged

Poll the emulator ledger instead of racing its write#1661
RhysSullivan merged 1 commit into
mainfrom
e2e-emulator-ledger-poll

Conversation

@RhysSullivan

Copy link
Copy Markdown
Collaborator

Fifth and last remaining CI e2e flake from PR #1648's runs: google-health-checks asserted the Google emulator's request ledger contains the health-check operations with a single ledger.list immediately after the probes. The probes had already come back healthy — which only the emulator can answer — but the hosted emulator acknowledges a request before its ledger entry is readable, so the one-shot read raced the write.

The scenario now polls the ledger (500ms spaced, up to 10s) until every expected operation is visible; on timeout the assertion names which preset's operation never arrived.

Verified: lint, e2e typecheck, and the scenario passes locally against a cloud stack and the hosted emulator.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 18, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing 152d8f6 Commit Preview URL

Branch Preview URL
Aug 18 2026, 05:31 PM

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Cloudflare preview

Torn down — the PR is closed.

@pkg-pr-new

pkg-pr-new Bot commented Aug 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@1661

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@1661

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@1661

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@1661

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@1661

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@1661

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@1661

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@1661

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@1661

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@1661

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@1661

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@1661

executor

npm i https://pkg.pr.new/executor@1661

commit: 152d8f6

@RhysSullivan
RhysSullivan marked this pull request as ready for review August 18, 2026 17:37
@RhysSullivan
RhysSullivan merged commit 41ec2d6 into main Aug 18, 2026
43 checks passed
@RhysSullivan
RhysSullivan deleted the e2e-emulator-ledger-poll branch August 18, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant