Draft
Conversation
ShadauxCat
reviewed
Apr 17, 2026
| builder.Append(Message); | ||
| } | ||
|
|
||
| public Context With(object key, object value) |
Collaborator
There was a problem hiding this comment.
I think this naming is a bit too vague. If I didn't have the context of a diff to see what it's replacing, I wouldn't be able to figure out what it's supposed to do. I propose naming it something like WithTag or WithLabel.
ShadauxCat
reviewed
Apr 17, 2026
| } | ||
| } | ||
|
|
||
| private void WatchForSingleton() |
Collaborator
There was a problem hiding this comment.
What happens here if someone changes scenes and creates a new NetworkManager rather than reusing the previous one (like, say, if they're switching from a lobby to an instanced game so they're changing to a new session)? Or if multiple NetworkManagers exist at once as in our tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
ContextualLoggerclass that can hold references to aNetworkManagerand a GameObjectILogContextinterface to standardize how LogContexts can be written to a builderContextstruct that is passed to the functions on theContextualLoggerto collect information about specific callsitesNetworkManager,NetworkManagerHelper, andNetworkManagerEditor.ContextualLoggerJira ticket
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports