fix(web): guard price axis fraction digits - #8055
Open
ayaanoncrypto wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8054
Summary
The price-axis formatter passed unvalidated
decimalsvalues into bothminimumFractionDigitsandmaximumFractionDigits. A malformed or out-of-range precision value causesIntl.NumberFormatto throwRangeError: maximumFractionDigits value is out of range.This change validates that the precision is an integer from 0 through the Intl-supported maximum of 100. Invalid values use the existing standard fiat formatter instead of constructing an invalid formatter. Regression coverage verifies valid fixed-precision formatting and the fallback path for precision above the limit.
Testing
node /tmp/uniswap-8054-intl-smoke.jsgit show --check HEADERR_PNPM_ENOSPC. CI should run the full repository checks.