Feat(#2) : Add Equalizer on axis renderer and add hands-off detector#168
Open
manoukianv wants to merge 26 commits into
Open
Feat(#2) : Add Equalizer on axis renderer and add hands-off detector#168manoukianv wants to merge 26 commits into
manoukianv wants to merge 26 commits into
Conversation
Ultrawipf
force-pushed
the
ultrawipf/testing
branch
from
7a6ae9e to
e4df0e7
Compare
manoukianv
force-pushed
the
feat/equalizer_handsoff
branch
3 times, most recently
from
c40e9ee to
56dce4b
Compare
manoukianv
force-pushed
the
feat/equalizer_handsoff
branch
from
56dce4b to
15d53f8
Compare
manoukianv
force-pushed
the
feat/equalizer_handsoff
branch
from
15d53f8 to
efd6cde
Compare
manoukianv
force-pushed
the
feat/equalizer_handsoff
branch
from
60f90a0 to
ae2d1e4
Compare
Ultrawipf
reviewed
May 28, 2026
| return -powf(-torquef,expo) * 0x7fff; | ||
| }else{ | ||
| return powf(torquef,expo) * 0x7fff; | ||
| int32_t Axis::calculateFFBTorque(){ |
Owner
There was a problem hiding this comment.
Converting back and forth between float and int32/16b int may lose resolution
Ultrawipf
reviewed
May 28, 2026
| BiquadType type = BiquadType::peak; | ||
| if (idx == 0) type = BiquadType::lowshelf; | ||
| else if (idx == num_eq_bands - 1) type = BiquadType::highshelf; | ||
| eqFilters[idx].setBiquad(type, eq_frequencies[idx] / filter_f, 2.14f, 0.0); |
Owner
There was a problem hiding this comment.
Eq filters are not recalculated when the sample rate changes by updateSamplerate.
Ultrawipf
reviewed
May 28, 2026
|
|
||
| // STEP 3: Add endstops | ||
| // Note: Historically endstops are added before the Master Scaler. | ||
| // If hard endstops (like Simucube) are desired, this should be moved to STEP 5. |
Owner
There was a problem hiding this comment.
it should absolutely not be moved after the scaling. everything MUST be scaled or you blow up your psu and bypass the scaler which in the case of the tmc is the actual current limit
- Change forces array from int64_t to int32_t to avoid unnecessary 64-bit math overhead. - Deduplicate sine phase calculation using MATH_PI and MATH_SIN macros. - Restore magnitude/offset assignment in HidFFB instead of EffectsCalculator to maintain separation of concerns.
- Prevents breaking SerialFFB and other sources that don't push samples to the reconstruction filter.
- Use MATH_PI, MATH_SIN, and MATH_COS macros to remove duplicate ifdef blocks for direction calculations. - Fix Z-axis calculation missing DSP optimizations.
manoukianv
force-pushed
the
feat/equalizer_handsoff
branch
from
5676cf7 to
dc59753
Compare
…e struct from 64 to 32b to reduce load.
manoukianv
force-pushed
the
feat/equalizer_handsoff
branch
from
6c36334 to
ffb8ac4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.