Skip to content

feat: enable custom timeout in get_httpx_client_kwargs - #1841

Open
hamarg wants to merge 5 commits into
mainfrom
feat/custom_timeout
Open

feat: enable custom timeout in get_httpx_client_kwargs#1841
hamarg wants to merge 5 commits into
mainfrom
feat/custom_timeout

Conversation

@hamarg

@hamarg hamarg commented Aug 3, 2026

Copy link
Copy Markdown

Development Packages

uipath

[project]
dependencies = [
  # Exact version (copy-paste ready):
  "uipath==2.13.21.dev1018417393",

  # Any version from this PR (uncomment to use a range instead):
  # "uipath>=2.13.21.dev1018410000,<2.13.21.dev1018420000",
]

[[tool.uv.index]]
name = "testpypi"
url = "https://test.pypi.org/simple/"
publish-url = "https://test.pypi.org/legacy/"
explicit = true

[tool.uv.sources]
uipath = { index = "testpypi" }
uipath-platform = { index = "testpypi" }

[tool.uv]
override-dependencies = ["uipath-platform==0.2.17.dev1018417393"]

uipath-platform

[project]
dependencies = [
  # Exact version (copy-paste ready):
  "uipath-platform==0.2.17.dev1018417393",

  # Any version from this PR (uncomment to use a range instead):
  # "uipath-platform>=0.2.17.dev1018410000,<0.2.17.dev1018420000",
]

[[tool.uv.index]]
name = "testpypi"
url = "https://test.pypi.org/simple/"
publish-url = "https://test.pypi.org/legacy/"
explicit = true

[tool.uv.sources]
uipath-platform = { index = "testpypi" }

Copilot AI review requested due to automatic review settings August 3, 2026 18:39
@github-actions github-actions Bot added test:uipath-langchain Triggers tests in the uipath-langchain-python repository test:uipath-integrations labels Aug 3, 2026
@hamarg hamarg added the build:dev Create a dev build from the pr label Aug 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a configurable request timeout to the shared httpx client configuration helper and exposes that timeout through the Orchestrator Attachments upload APIs, so callers can tune upload behavior for larger payloads or slower networks.

Changes:

  • Add a timeout parameter to get_httpx_client_kwargs() and use it when building client kwargs.
  • Add a timeout parameter to AttachmentsService.upload() / upload_async() and thread it into the anonymous blob upload httpx clients.
  • Switch the async upload path to use httpx.AsyncClient for the non-authenticated blob upload branch.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/uipath-platform/src/uipath/platform/orchestrator/_attachments_service.py Adds timeout to attachment upload APIs and passes it into the httpx client used for blob uploads.
packages/uipath-platform/src/uipath/platform/common/_http_config.py Adds a configurable timeout argument to the shared httpx client kwargs helper.
Suppressed comments (1)

packages/uipath-platform/src/uipath/platform/orchestrator/_attachments_service.py:710

  • timeout isn’t applied to the authenticated blob upload path (RequiresAuth == True) in the async implementation either: request_async(...) is called without timeout, so timeout= only affects the anonymous upload (httpx.AsyncClient(...)) branch.
                    await self.request_async(
                        "PUT", upload_uri, headers=headers, content=file_content
                    )
                else:
                    async with httpx.AsyncClient(

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/uipath-platform/src/uipath/platform/common/_http_config.py
@sonarqubecloud

sonarqubecloud Bot commented Aug 3, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build:dev Create a dev build from the pr test:uipath-integrations test:uipath-langchain Triggers tests in the uipath-langchain-python repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants