Skip to content

Avoid tiny numpy arrays in numba: optimize area.py #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sevans711 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Avoid tiny numpy arrays in numba: optimize area.py #1701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e724b5
optimize: avoid tiny numpy in numba: area.py
Sevans711 Aug 21, 2026
d3bea39
pre-commit ruff formatting
Sevans711 Aug 21, 2026
e384572
fix area.py optimizations typo
Sevans711 Aug 21, 2026
e4061c6
ruff formatting
Sevans711 Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions test/grid/grid/test_areas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,3 +196,17 @@ def test_total_face_area_honors_quadrature_kwargs():
np.sum(uxgrid.compute_face_areas(quadrature_rule="gaussian", order=2)),
rtol=0,
)

def test_face_area_invalid_order_crashes():
"""spot check: using invalid values for order needs to raise ValueError"""
uxgrid = ux.Grid.from_healpix(zoom=2)
with pytest.raises(ValueError):
uxgrid.compute_face_areas(quadrature_rule="gaussian", order=0)
with pytest.raises(ValueError):
uxgrid.calculate_total_face_area(quadrature_rule="triangular", order=3)
with pytest.raises(ValueError):
uxgrid.compute_face_areas(quadrature_rule="triangular", order=7)
with pytest.raises(ValueError):
uxgrid.calculate_total_face_area(quadrature_rule="gaussian", order=12)
# 12 is valid for triangular but not for gaussian. Just ensuring this doesn't crash:
uxgrid.compute_face_areas(quadrature_rule="triangular", order=12)
Loading
Loading