[mmcleod89]

Major changes to graphics and some game functionality.

Music and sound effects have been added but may still be buggy if you don't start from the beginning as they are persistent objects across scenes.

There are some easy to add features that aren't present that will need to be added namely:

• The text introduction for most of the games; I believe the text for this is in a document that we have been sent but I no longer have access to it because IT updating my computer to work with Windows Defender corrupted something and I can no longer open most of my word documents.
• Music needs to be picked for some of the games.

[thompson318]

@mmcleod89 Is this ready for review?

[thompson318]

@mmcleod89 I haven't looked at code or structure yet, just done a quick play test on my Surface (which I think has the wrong aspect ratio). In general it looks and sound great. There were a few bugs for me which I haven't investigated yet. I've marked them in bold below.

1. I would like to be able to turn off the music.
2. Rocket Launch instructions and demo work - eye and head tracking good.
3. Star Collector - demo is good. No text instructions as noted above.
4. Mission Star Seek - all works - sound is good
5. Mission Star map. Demo is clear. If I click straight through to the game it works OK. However if I do demo first then click start I start playing Star Collector. If I complete the level then press start again I end up at Rocket Launch.
6. Space Walking - Demo - the next button is behind the menu button (this might not be an issue on a tablet with the right aspect ratio) Otherwise seemed to work.
7. Zero gravity - worked. The visor didn't go grey for eyes shut. The countdown sound never stopped, so when I went back to main menu or played other games t was still sounding.

Update: - Some of the above bugs (rocket launch not working and no timer in star collector) were due to old format data being present in the save directory, which caused failures at level start up. Clearing the data directory fixed them (and I have deleted them from the comments above).

More update: Star map bugs are due to Scenes/StarMap/DemoStarMap.unity calling LoadStarCollectorInstructions instead of LoadStarMapInstructions. Not sure if that came in with this PR or not. Still working on it.

[thompson318]

Game is looking and sounding great and plays well mostly. I liked the demo screens, I think they get the mechanics over well.

Very difficult to review so many changes in one go, so most of this I've just skimmed. I played the game through and found a couple of bugs. Added code suggestions that hopefully fix them.

[mmcleod89]

@thompson318 I will fix the sound and linking issues now and let you know when they're ready.
The sounds / music that I added are CC0 which is as freely reusable as they come, but we should double check with david herdman how the usage of the envato sounds works with the licensing.

[mmcleod89]

@thompson318 This should fix issues with music / sfx not stopping properly, and address the linking issues. (The links on the win screen for all of the games actually needed to be set properly.)
I've changed the anchoring of the next button so it should now be calculated from the bottom left instead of the centre, which should fix the placement if you're playing with a different aspect ratio.

[thompson318]

This looks good and plays well for me. It would be good to get it merged and then address any minor improvements in separate PRs. Suggestions for future PRs;

• Option to turn off music
• Zero gravity sounds (count down and balance noise) continue to win screen which feels slightly odd. But they do stop when you exit winscreen and return to main menu, so OK for now.

[mmcleod89]

I think turning off the music can be a separate PR (but will be easy to implement, I just need a new button for it), but I'll fix the sounds going on for the win-screen since that should be easy and will make this feel more complete.

[mmcleod89]

@thompson318 This should sort out the game sounds continuing after the winscreen (the coroutine was not properly ended), and I agree that we can put any further tweaks into future PRs. The "eyes closed" visor can be deferred until we do the graphics update since they'll just have to be replaced anyway.