fix(compat): ignore an external git differ, drop locale env prefixes - #914
Closed
Chemaclass wants to merge 1 commit into
Closed
fix(compat): ignore an external git differ, drop locale env prefixes#914Chemaclass wants to merge 1 commit into
Chemaclass wants to merge 1 commit into
Conversation
Three failures reported in #912, none of them visible to CI: - render_diff ran `git diff` without `--no-ext-diff`, so a user's `diff.external` (difftastic) replaced the word-diff with its own output and the multiline/snapshot failure diffs came out empty. - `bashunit::clock::shell_time` and the JUnit report prefixed a command with `LC_ALL=C`, reported to segfault inside a command substitution on Bash 5.3.9 macOS. `env LC_ALL=C cmd` keeps awk's radix a dot without bash touching its own locale; shell_time never needed it at all, since the value is expanded before the temporary environment applies. - The syntax-error acceptance test used the same prefix form. A source-level gate in bash_compatibility_test.sh keeps the prefix out of src/, since no CI job runs Bash 5.3 on macOS. Closes #912
2 tasks
Member
Author
|
Closing in favour of #913, which reported and fixed the same three bugs first. Everything this PR had that #913 was missing is now on that branch: the #913 also carries two fixes this PR did not have: the init acceptance test writes its log under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Related #912
Seven tests failed on macOS with Bash 5.3 under
nix-shell --pure, and two more for anyone with an external git differ configured. CI never sees either: macOS runners ship Apple's Bash 3.2, and no runner hasdiff.externalset.💡 Changes
--no-ext-diff, so a configureddiff.external(difftastic) no longer replaces the word-diff with empty output.LC_ALL=C cmd), reported to segfault inside a command substitution on Bash 5.3.9 macOS.env LC_ALL=C cmdkeeps the C radix; the clock never needed the prefix, since the value is expanded before the temporary environment applies.src/, since no CI job runs that bash.