chore: drop the vendored bin/create-pr - #892
Merged
Merged
Conversation
A 476-line copy of Chemaclass/create-pr v0.10 that nothing referenced: not the Makefile targets, the workflows, the pr skill, or the docs, which link the upstream project rather than this copy. Having no .sh extension it was invisible to `make sa` until #863 added it explicitly, so it sat in the tree written in a Bash 4 style (`[[ ]]` throughout) that the project's own compatibility rules prohibit. Also drops it from the `sa` target's file list, the one live reference. Closes #867
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Related #867
bin/create-prwas a 476-line vendored copy of Chemaclass/create-pr v0.10. Nothing referenced it — not theMakefiletargets, the workflows, theprskill, or the docs, which link the upstream project rather than this copy. PRs here are opened with theprskill, so the vendored copy has no remaining role.💡 Changes
bin/create-pr.satarget's explicit file list, the one live reference. Having no.shextension it had been invisible tomake sauntil docs: stop instructing shfmt -w, and scope make sa correctly #863 added it, which is what exposed that it is written in a Bash 4 style ([[ ]]throughout) the project's own compatibility rules prohibit.