You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
expands the map view out of the centered app content box so it reaches edge-to-edge
widens the bottom search control by using the full map overlay width
changes Ask AI into an icon-only round button inside the search field suffix
shows the AI action only while the search field is focused
disables map rotation gestures so the map stays oriented more predictably
Stacking
This PR is stacked on #25 and contains the follow-up refinement feedback only. Merge #25 first, then this PR can be retargeted to main or merged after the base branch is available.
Verification
/tmp/studyos-tools/flutter/bin/flutter analyze
/tmp/studyos-tools/flutter/bin/flutter test test/maps_controls_test.dart test/navigation_test.dart test/map_location_models_test.dart
Reviewed the stacked follow-up diff. Intent looks clear: keep the map full-width, widen the bottom overlay, move the assistant affordance into the search suffix, hide it until search focus, and disable map rotation.
No blocking code findings from the stacked diff. The main risk areas I checked were scaffold/layout regressions from letting only AppView.maps escape the 760px content constraint, focus-driven visibility for the Ask AI action, and whether map controls still expose search/open/assistant actions through tests.
Verification run locally from the PR head:
/tmp/studyos-tools/flutter/bin/flutter analyze
/tmp/studyos-tools/flutter/bin/flutter test test/maps_controls_test.dart test/navigation_test.dart test/map_location_models_test.dart
/tmp/studyos-tools/flutter/bin/flutter test
Smallest useful next action: since #25 is now merged, retarget this PR from issue-24-map-assistant-ui to main, then wait for the pending Flutter CI check to finish before a human merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ask AIinto an icon-only round button inside the search field suffixStacking
This PR is stacked on #25 and contains the follow-up refinement feedback only. Merge #25 first, then this PR can be retargeted to
mainor merged after the base branch is available.Verification
/tmp/studyos-tools/flutter/bin/flutter analyze/tmp/studyos-tools/flutter/bin/flutter test test/maps_controls_test.dart test/navigation_test.dart test/map_location_models_test.dart/tmp/studyos-tools/flutter/bin/flutter test