feat(app): add maps navigation page#23
Merged
Merged
Conversation
Contributor
Author
|
Reviewed the PR for the new Maps page. I do not see a blocking code issue from the diff: the feature is scoped to the Flutter app, avoids current-location permissions, keeps selected-location context explicit before handing it to the assistant, and adds basic parsing/navigation coverage. Likely risk areas to keep in view before merge:
Smallest useful next step: wait for the Flutter CI result, then do one manual smoke test of: open Map tab, search a Tuebingen destination, select a result, click “Ask StudyOS”, and click external maps. If CI passes and that smoke test works, this looks ready for human review/merge consideration. |
Collaborator
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flutter_map/ OpenStreetMap tiles and a Nominatim search client for Tuebingen destinations.Notes
Verification
dart format --output=none --set-exit-if-changed lib testflutter analyzeflutter testCloses #22