Adding replacement-submodes#974
Open
JohanEntur wants to merge 1 commit into
Open
Conversation
JohanEntur
requested review from
Aurige,
TuThoThai,
skinkie,
trurlurl and
ue71603
JohanEntur
added
the
change-request
TuThoThai
previously approved these changes
Dec 11, 2025
Contributor
There was a problem hiding this comment.
Approved during the plenary of 21 November 2025 but under these conditions:
- NeTEx v2.0 needs to be released first
- PR has to target the future branch v2.1
- This is a quick fix before work v3.0 during with the work on TransportMode will be carrried out
trurlurl
approved these changes
Dec 11, 2025
ue71603
approved these changes
Jul 8, 2026
ue71603
left a comment
ue71603
left a comment
Contributor
There was a problem hiding this comment.
we once had a railReplacementHelicopter :-)
Contributor
|
Why not take the approach where we remove all 'replacements' and have a separate 'ReplacementTransportType' that can link to any known modes? |
Contributor
|
We could, but if we go down that road, then we would perhaps to think about ALL "actions" that can happen to one or several journeys. |
Contributor
Author
|
This was just an emergency fix imho. In my suggestions regarding TransportMode, this problem would no longer be relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to actual traffic needs, we would like to add a few more enums to NeTEx to properly cover the granulation of transport offers.
This also proves my old point about the need to reform TransportMode/TransportSubmode :)