Repository navigation
Conversation
Contributor
Author
|
redoing #958 TODO:
|
ue71603
marked this pull request as ready for review
September 24, 2025 12:01
Contributor
Author
|
We can now have the discussion
|
skinkie
reviewed
Sep 24, 2025
skinkie
reviewed
Sep 24, 2025
skinkie
reviewed
Sep 24, 2025
skinkie
reviewed
Sep 24, 2025
skinkie
reviewed
Sep 24, 2025
skinkie
reviewed
Sep 24, 2025
…rictions_version.xsd Co-authored-by: Stefan de Konink <stefan@konink.de>
…_version.xsd Co-authored-by: Stefan de Konink <stefan@konink.de>
…_version.xsd Co-authored-by: Stefan de Konink <stefan@konink.de>
…_version.xsd Co-authored-by: Stefan de Konink <stefan@konink.de>
ue71603
commented
Sep 24, 2025
ue71603
commented
Sep 24, 2025
…b.com/TransmodelEcosystem/NeTEx into extend_service_restrictions_new_modes
- still updating README - clarifying possbilitlities for DRT - allowing Name/Description for all substitutes for a ServiceBookingArrangement
…b.com/TransmodelEcosystem/NeTEx into extend_service_restrictions_new_modes
- Added TransferDelay (like HRDF) as a choice to the TransferRestriction - allowed MinimumDriveduration and MaximumDriveDuration (HRDF style) in ServiceCompetitiveCondition - having the different ServicecompetitiveCondition "types" in different parts of a choice
…b.com/TransmodelEcosystem/NeTEx into extend_service_restrictions_new_modes
…b.com/TransmodelEcosystem/NeTEx into extend_service_restrictions_new_modes
…b.com/TransmodelEcosystem/NeTEx into extend_service_restrictions_new_modes
Comment on lines
+125
to
+192
| <xsd:choice> | ||
| <xsd:sequence> | ||
| <xsd:group ref="RoutingConstraintInFrameGroup" minOccurs="0"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Restrictions in what the SERVICE is allowed to do in connection with other SERVICES. If not set, then the rules apply in general.</xsd:documentation> | ||
| </xsd:annotation> | ||
| </xsd:group> | ||
| <xsd:element name="MinimalDistanceFromClassical" type="xsd:integer" minOccurs="0"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Distance in metres to the line/service or classical public transport in general. This is defined as the minimum walking distance from the next StopPlace of a classical public transport. Be aware that this is NOT to be taken into account for StopPlaces where a transfer is intended and defined (e.g. at a railway station). </xsd:documentation> | ||
| </xsd:annotation> | ||
| </xsd:element> | ||
| <xsd:element name="TemporalDistanceFromClassicalBefore" type="xsd:duration" minOccurs="0"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Temporal distance to the SERVICE / transfer in the RoutingConstraint or classical public transport in general (before the departure at a reasonably nearby stop).</xsd:documentation> | ||
| </xsd:annotation> | ||
| </xsd:element> | ||
| <xsd:element name="TemporalDistanceFromClassicalAfter" type="xsd:duration" minOccurs="0"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Temporal distance to the SERVICE / transfer in the RoutingConstraint or classical public transport in general (after the departure at a reasonably nearby stop).</xsd:documentation> | ||
| </xsd:annotation> | ||
| </xsd:element> | ||
| </xsd:sequence> | ||
| <xsd:sequence> | ||
| <xsd:element name="PenaltyTravelTimeFactor" type="xsd:decimal" default="1.0" minOccurs="0"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Factor to multiply the classical public travel time with for the calculation of the dominance of the demand responsive traffic.</xsd:documentation> | ||
| </xsd:annotation> | ||
| </xsd:element> | ||
| <xsd:element name="PenaltyTravelTimeOffset" type="xsd:duration" default="PT0S" minOccurs="0"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Offset in the calculation for the dominance of demand responsive traffic.</xsd:documentation> | ||
| </xsd:annotation> | ||
| </xsd:element> | ||
| <xsd:element name="PenaltyTransferTimeFactor" type="xsd:decimal" default="1.0" minOccurs="0"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Factor to multiply the classical public transfer times with for the calculation of the dominance of the demand responsive traffic.</xsd:documentation> | ||
| </xsd:annotation> | ||
| </xsd:element> | ||
| <xsd:element name="WalkTimeFactor" type="xsd:decimal" default="1.0" minOccurs="0"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Factor to multiply walk time for the classical public transport to calculate if the classical public transport still should dominate the demand responsive traffic.</xsd:documentation> | ||
| </xsd:annotation> | ||
| </xsd:element> | ||
| <xsd:element name="MinimumTravelDuration" type="xsd:duration" default="PT0S" minOccurs="0"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Minimal travel duration that is allowed to use the service.</xsd:documentation> | ||
| </xsd:annotation> | ||
| </xsd:element> | ||
| <xsd:element name="MaximumTravelDuration" type="xsd:duration" minOccurs="0"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Maximum travel duration that is allowed for the service.</xsd:documentation> | ||
| </xsd:annotation> | ||
| </xsd:element> | ||
| </xsd:sequence> | ||
| <xsd:sequence> | ||
| <xsd:element name="InterchangeBetweenFlexibleServicesAllowed" type="xsd:boolean" default="false" minOccurs="0"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Interchange between different flexible services is allowed.</xsd:documentation> | ||
| </xsd:annotation> | ||
| </xsd:element> | ||
| <xsd:element name="InterchangeWithConventionalServicesAllowed" type="xsd:boolean" default="false" minOccurs="0"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Interchange between the flexible service and conventional services is allowed.</xsd:documentation> | ||
| </xsd:annotation> | ||
| </xsd:element> | ||
| </xsd:sequence> | ||
| </xsd:choice> |
There was a problem hiding this comment.
This lacks a clear formula and definitions.
In its current state, every journey planner and booking system would interpret those parameters differently as they like.
Please do not standardize it in this state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the first major overhaul of the DRT part. It is based on the discussions on Basecamp: https://3.basecamp.com/3256016/buckets/2570434/messages/9445596013
Documents here: https://3.basecamp.com/3256016/buckets/2570434/vaults/9446713460
Some open questions will be deferred to a later PR or several as to not overload this one.
As this is a 2.1-wip PR: changes to existing functionality should be avoided.
Open points:
README: Remove German parts
README: Improve readability
README Descriptions in examples should describe, what happens
README Copy better examples for the different types
Positiv list for possible transfers to regular public transport (perhaps directly in the flexible area) (or in ServiceCompetitiveCondition
Include MOTIS input: Input from Felix Gründling for more parameters: https://felixguendling.github.io/transit-qa/
- This would also allow for perpiece linear functions in the form of a table
- from 0 mim taxi: 35 penalty points per taxi minute
- from 1 min taxi: 12 penalty points per taxi minute
- So a penalty factor for DRTis missing
- DistanceFromClassical seems problematic, as an existing line may not operate (at this hour).
- There may be other dominance rules for DRT vs DRT (first -mile/last-mile DRT vs direct DRt)
DONE:
- need for reservation
- no bicyles allowed
- additional fare necessary
- *R * U 5 additional time for transfer at stop
- *R *DT 14 14 no competition to classical line
- *SS *FAT 00 30 Minimal-maximal drive duration.
BookingUrlforBookingArrangement