Repository navigation
Release without Grafana's catalog validator; run CI on main - #2
Merged
Merged
Conversation
The v2.0.0 release failed in grafana/plugin-actions/build-plugin. That action runs Grafana's catalog-submission validator (@grafana/plugin-validator@latest) as a hard gate, and it reported three errors: - "organization not found": the catalog requires the plugin ID's prefix (transitapp) to be a registered Grafana Cloud account. - Relative links in the README, which the catalog cannot resolve. - High-severity advisories in package-lock.json for basic-ftp and braces. This plugin is installed directly, not published to the catalog, so the release workflow now builds, tests and packages it itself and publishes a GitHub release with the zip, its sha1, and the latest CHANGELOG section as notes. It checks that the tag matches package.json's version. Two other reasons to drop the action: braces has no fixed release (every version through 3.0.3, the latest, is affected), so the scanner would block every release regardless; and the action pulls its packaging step from @main and the validator from @latest, so the rules a release must pass change without notice. Grafana's plugin.json check still runs in CI. If the plugin ever goes to the catalog, switch back to build-plugin. Also fixed: - basic-ftp: overridden to ^6.2.2. Nothing upstream offers a fixed version; even the latest get-uri, via @grafana/sign-plugin's proxy support, wants 5.x. 6.0's only breaking change disables separate FTP transfer hosts, which get-uri does not use. braces is dev-only (jest, eslint-webpack-plugin) and not in the bundle. - README links are absolute, and the screenshot and licence URLs point at main; they pointed at master, which does not exist here, and returned 404. - CI and CodeQL only ran on master, so they never ran on this repo, including on the PR that merged the modernisation. They now run on main, and CodeQL moves to its current major, v4. - The release uses the Node version in .nvmrc (22); the action defaulted to 20. The README gains an Installation section with the Helm values, and CONTRIBUTING describes the new release steps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v2.0.0 release failed in grafana/plugin-actions/build-plugin. That action runs Grafana's catalog-submission validator (@grafana/plugin-validator@latest) as a hard gate, and it reported three errors:
This plugin is installed directly, not published to the catalog, so the release workflow now builds, tests and packages it itself and publishes a GitHub release with the zip, its sha1, and the latest CHANGELOG section as notes. It checks that the tag matches package.json's version. Two other reasons to drop the action: braces has no fixed release (every version through 3.0.3, the latest, is affected), so the scanner would block every release regardless; and the action pulls its packaging step from @main and the validator from @latest, so the rules a release must pass change without notice. Grafana's plugin.json check still runs in CI. If the plugin ever goes to the catalog, switch back to build-plugin.
Also fixed:
The README gains an Installation section with the Helm values, and CONTRIBUTING describes the new release steps.